Honor configured IB port when querying RoCE GID - #202
Merged
Merged
Conversation
|
|
thesues
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open_rdma_device()selects the GID index using the configured IB port, but queries the GID from port 1. With--ib-port 2, this can return the wrong GID or fail. Userdma_dev->ib_portfor the query as well.Add a Meson test that calls the real device-opening code with mocked verbs. It covers ports 1 and 2 with automatic and explicit GID index selection, without RDMA hardware.
meson setup build src -Dwerror=true meson test -C build --suite rdma-device --print-errorlogsValidation: both port-2 cases fail before the fix; all four pass after it. The test target compiles with
-O3 -g -Wall -Wextra -Werror, and repository-wide pre-commit checks pass. A full extension build with-Werroris blocked by warnings in unchanged files, includingibv_helper.cppandmempool.cpp. Multi-port hardware testing was not performed.