Skip to content

Delay benchmark event loop startup - #204

Open
ToLiveAndLove wants to merge 1 commit into
bytedance:mainfrom
ToLiveAndLove:fix/benchmark-help-exit
Open

ToLiveAndLove wants to merge 1 commit into
bytedance:mainfrom
ToLiveAndLove:fix/benchmark-help-exit

Conversation

@ToLiveAndLove

Copy link
Copy Markdown
Contributor

Start the benchmark event loop only for RDMA benchmark runs. This allows --help and argument parsing errors to exit normally and avoids an unused background thread for TCP benchmarks.

Add an isolated CLI regression test.

Validation:

  • CLI regression test passes.
  • A TCP benchmark completes successfully.
  • Pre-commit checks pass.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant