Repository navigation
test(app): cover named/opt route helpers and set_session_max_age (closes #390) - #394
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Adds
tests/test_app_route_helpers.ccovering the nine route-registration helpers that were listed inscripts/ci/api-untested-baseline.txt:cwist_app_get_named,cwist_app_put_named,cwist_app_patch_named— register named routes and confirmcwist_url_forresolves them.cwist_app_get_opt,cwist_app_post_opt,cwist_app_put_opt,cwist_app_patch_opt,cwist_app_delete_opt— smoke-test with a zeroedcwist_endpoint_opt_t; assert no crash and route resolves.cwist_app_set_session_max_age— call with positive, zero, and NULL app; assert no crash.Pattern follows
tests/test_app_named_routes_and_error_handler.c(#388): registration-and-lookup only, no live server.How verified
Target compiles and exits 0.
Exits 0; the nine covered names are removed from
scripts/ci/api-untested-baseline.txt.What this does NOT do
Does not test started servers, TLS, websocket, or any database path.