refactor(website): substrate migration batch 4 — landing blocks off inline styles - #852
Merged
Conversation
blove
enabled auto-merge (squash)
August 29, 2026 21:40
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
blove
force-pushed
the
blove/style-substrate-batch-4
branch
from
August 29, 2026 21:48
28428f5 to
90eb6fd
Compare
Contributor
blove
force-pushed
the
blove/style-substrate-batch-4
branch
from
August 29, 2026 21:53
90eb6fd to
e58d278
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Batch 4 of the substrate migration (plan, Task 4): the 17
components/landingfiles move tosrc/styles/landing.css, including hoisting the embedded<style>tags (the third styling substrate) — their${tokens.*}interpolations becomevar(--*)and the per-instance duplicated<style>elements disappear from the DOM.Three commits: hero + feature blocks, the section strip, demo/media + the three code showcases.
Verified: three pages signature-identical to production
Aggregate per-page signatures (element count + tag-order hash + hash-of-per-element-hashes over 26 computed properties, pinned 1280×900, scroll pinned to top):
//langgraph/ag-uiPlus vitest at the pre-existing baseline (
5 failed | 341 passed— includingDifferentiator.spec's content drift, unchanged), 0 lint errors, prod build green.Judgment calls (flagged by the implementer, accepted after verification)
HighlightedCodeoverrides the shared.shikibackground; as an inline style it always won, but stylesheet-vs-stylesheet it needed real specificity — now.shiki[data-ui="highlighted-code"]. The signature match on/langgraphproves the cascade lands where the inline style did.DemoModal's active tab reuses the existingaria-selectedattribute as its styling hook instead of a newdata-*.The homepage's known 320px overflow bugs migrate verbatim, unfixed — they belong to the polish arc.
🤖 Generated with Claude Code