refactor(website): substrate migration batch 6a — docs pages off inline styles - #856
Merged
Conversation
Batch 6a (1/2): app/docs/page.tsx and app/docs/licensing/page.tsx move their static presentation — shape-D CSSProperties variables (headingStyle, bodyStyle, cellStyle, stepLabelStyle, etc.) and one-off literal style objects — into src/styles/pages.css as page-prefixed classes (.docs-index-*, .licensing-*). Values move verbatim; GlyphChip's size-driven width/height stay inline (unbounded prop). The supporting-libraries card header keeps its own class (.docs-index-card-header-inline) rather than reusing .docs-index-card-header, since its source object omits the shared style's margin-bottom.
Batch 6a (2/2): app/docs/choosing-an-adapter/page.tsx moves its hero maxWidth and Eyebrow spacing to .adapter-* classes (its --tw-prose-* custom-prop object stays inline, same escape hatch as MdxRenderer). The docs shell (app/docs/[library]/[section]/[slug]/page.tsx) moves its background + paddingTop into .docs-shell-page/.docs-shell-body verbatim — the known paddingTop:80 / overflow-x-hidden defects are untouched, left for a later project.
blove
enabled auto-merge (squash)
August 29, 2026 22:44
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Batch 6a of the substrate migration (plan, Task 6a): the four docs-adjacent route files move to
src/styles/pages.css. This is the shape-D showcase — 23 namedCSSPropertiesvariables covering 111 style sites collapse to 45 classes.The docs shell (
[library]/[section]/[slug]/page.tsx) migrates itspaddingTop: 80and keepsoverflow-x-hiddenverbatim — those are known defects owned by the polish arc, not this migration.Verified: four pages signature-identical to production
/docs/docs/licensing/docs/choosing-an-adapter/docs/chat/components/chat(full shell)Plus
nx test websitefully green (347), 0 lint errors, prod build green (294 pages).A caught near-miss worth reading
The implementer's self-review caught a genuine zero-visual-change violation before it shipped: three docs-index card headers share a
cardHeaderStylewithmarginBottom: 12, but a fourth call site omits the margin. The first collapse pass unified all four onto one class — which would have added 12px to that card. It now has its own.docs-index-card-header-inlineclass, documented inpages.css. The signature match on/docsconfirms the fix.🤖 Generated with Claude Code