chore(website): post-arc follow-ups — delete dev route, guard to error - #866
Merged
Conversation
…pressions Second commit of the post-arc follow-ups. Rather than the planned 18 eslint-disable comments, every remaining dynamic-value site converts to the rule's own patterns, so the guard enforces with no exceptions ledger at all: - GlyphChip size, CardGroup columns, CompareTable's tier-driven CTA grid, the solutions pages' per-page accent, and BrowserFrame's rotate/maxWidth all become custom-property escape hatches with CSS consumers. - AnnouncementToast's entrance animation becomes a data-mounted state pair. Two cascade traps caught by prod-signature verification during the swap: - The accent rule needed [data-ui="eyebrow"][data-accent-text] to tie the Eyebrow tone rules' 0-2-0 specificity (the inline color it replaced used to outrank everything). - rotate(var(--x, 0deg)) computes to an identity MATRIX, not `none` - which silently creates a stacking context and fixed-position containing block on every un-rotated BrowserFrame. The tilt is now gated behind data-rotated. Verified value-preserving: /pricing, /docs, and /solutions/customer-support hash-identical to production at 1280 over 30 computed properties (including transform and min/max-width). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
blove
enabled auto-merge (squash)
August 30, 2026 14:12
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two of the three post-arc follow-ups, in two commits:
1. Delete the dev-only primitives route. Its own FAQ said "this route gets deleted once the marketing pages have migrated" — #848–#858 finished that. Removes the route, its e2e spec, and its lint-guard exemption.
2. Escalate the inline-style guard
warn→error— at zero suppressions. The plan anticipated 18 disable comments; instead every dynamic site converts to the rule's own patterns (custom-property escape hatches with CSS consumers; the toast's entrance animation becomes adata-mountedstate pair). The guard now enforces with no exceptions ledger at all.Two cascade traps caught by verification
color(outranks everything) to an attribute rule — which lost to Eyebrow's 0-2-0 tone rules until given a matching compound selector. Caught as a muted-grey eyebrow on the solutions pages by the prod-signature diff, localized to exactly the 5 eyebrow elements.rotate(var(--x, 0deg))≠none: the 0deg default computes to an identity matrix, which silently creates a stacking context and a fixed-position containing block on every un-rotated BrowserFrame. Caught as a single-element transform diff; the tilt is now gated behinddata-rotated.Verified
/pricing,/docs, and/solutions/customer-supporthash-identical to production at 1280 over 30 computed properties (the set now includestransform,min-width,max-width,opacity— widened specifically to catch conversions like these).nx test websitefully green, 0 lint errors, prod build green.Remaining follow-up (its own ticket): wiring cockpit apps to the generated
tokens.css— a real visual change per app.🤖 Generated with Claude Code