fix(ci): unbreak main — drop verify assertions for the removed pricing matrix - #915
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
blove
enabled auto-merge (squash)
September 1, 2026 03:04
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
…g matrix #908 tightened the pricing page, deleting CompatibilityMatrix.tsx along with the WEBSITE_ANGULAR_SUPPORT_ROWS and WEBSITE_PRICING_SUPPORT_SUMMARY exports. scripts/verify-angular-support.mjs still imported both, so the module throws at import: SyntaxError: The requested module '.../angular-support.mjs' does not provide an export named 'WEBSITE_ANGULAR_SUPPORT_ROWS' That fails `Library — lint / test / build`, which fails `CI — required`, so main has been red since e8dc1ba and every PR inherits it. The Supported-row, Planned-row and pricing-summary assertions verified copy that no longer renders anywhere, so they go with the matrix rather than being propped up by restored constants. WEBSITE_SUPPORTED_ANGULAR_MAJORS still backs live page content and is still checked against the registry, so the drift this script exists to catch — the website advertising Angular majors the packages do not support — stays covered. Prunes the eight spec cases that drove only the removed assertions; the remaining 15 pass, and `node scripts/verify-angular-support.mjs` exits 0. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
blove
force-pushed
the
blove/fix-angular-support-verify
branch
from
September 1, 2026 03:04
8c712cb to
23db321
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is red and every PR inherits it.
#908 tightened the pricing page, deleting
CompatibilityMatrix.tsxalong with theWEBSITE_ANGULAR_SUPPORT_ROWSandWEBSITE_PRICING_SUPPORT_SUMMARYexports.scripts/verify-angular-support.mjsstill imported both, so the module throws at import time:That fails
Library — lint / test / build→CI — required. Main CI has failed one8dc1ba4andc20ab69dsince.The fix
The Supported-row, Planned-row, and pricing-summary assertions verified copy that no longer renders anywhere, so they go with the matrix rather than being propped up by restored constants.
WEBSITE_SUPPORTED_ANGULAR_MAJORSstill backs live page content and is still checked against the registry — so the drift this script exists to catch (the website advertising Angular majors the packages don't support) stays covered.Prunes the eight spec cases that drove only the removed assertions.
Verification
Ran the library job's exact steps locally:
node --test examples/chat/smoke/*.spec.mjs scripts/verify-angular-support.spec.mjs→ 44 pass, 0 failnode scripts/verify-angular-support.mjs→Angular support metadata verified: 20, 21, 22, exit 0Note
If deleting the compatibility matrix was not intentional in #908, this is the wrong direction — the alternative is restoring
CompatibilityMatrix.tsxand both exports. I read "tighten the pricing page" as deliberate, but the author should sanity-check that call.🤖 Generated with Claude Code