feat: add operational sidebar control plane - #921
Merged
Conversation
…trol-plane # Conflicts: # .github/workflows/ci.yml # apps/website/src/components/docs/DocsControlPlane.tsx
…trol-plane # Conflicts: # apps/cockpit/src/components/cockpit-shell.spec.tsx # apps/cockpit/src/components/cockpit-shell.tsx
…trol-plane # Conflicts: # apps/website/src/components/docs/DocsControlPlane.tsx # apps/website/src/components/shared/Nav.tsx
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
blove
added a commit
that referenced
this pull request
Sep 1, 2026
#921 added apps/cockpit/e2e/control-plane.spec.ts — 7 Playwright tests over the operational sidebar: the real Angular handshake without blank or unresponsive states, operational controls reachable at four viewports, forced colors preserving control boundaries and keyboard focus, and reduced motion disabling loader and drawer animation. Nothing ever ran it. The suite sits behind `nx e2e cockpit`, and the cockpit-e2e matrix only dispatches caps derived from walking cockpit/** — apps/cockpit is never a candidate. No other job named the target either: grepping every workflow for `nx e2e` returns examples-chat-angular, examples-ag-ui-angular, the cap matrix, and website. So this has been dead coverage for its whole life. Verified it actually passes before wiring it up — 7/7 in 24s locally. It goes in the existing `cockpit` job rather than a new one because it is cheap, it reuses that job's `npm ci`, the `cockpit` scope already gates the shell, and required-pr-checks already aggregates the job — so it becomes merge-blocking with no gate change. The playwright config already sets retries: 2 on CI. Found while auditing the tags I removed from apps/cockpit in #939. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
blove
added a commit
that referenced
this pull request
Sep 2, 2026
#921 added apps/cockpit/e2e/control-plane.spec.ts — 7 Playwright tests over the operational sidebar: the real Angular handshake without blank or unresponsive states, operational controls reachable at four viewports, forced colors preserving control boundaries and keyboard focus, and reduced motion disabling loader and drawer animation. Nothing ever ran it. The suite sits behind `nx e2e cockpit`, and the cockpit-e2e matrix only dispatches caps derived from walking cockpit/** — apps/cockpit is never a candidate. No other job named the target either: grepping every workflow for `nx e2e` returns examples-chat-angular, examples-ag-ui-angular, the cap matrix, and website. So this has been dead coverage for its whole life. Verified it actually passes before wiring it up — 7/7 in 24s locally. It goes in the existing `cockpit` job rather than a new one because it is cheap, it reuses that job's `npm ci`, the `cockpit` scope already gates the shell, and required-pr-checks already aggregates the job — so it becomes merge-blocking with no gate change. The playwright config already sets retries: 2 on CI. Found while auditing the tags I removed from apps/cockpit in #939. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
blove
added a commit
that referenced
this pull request
Sep 2, 2026
#921 added apps/cockpit/e2e/control-plane.spec.ts — 7 Playwright tests over the operational sidebar: the real Angular handshake without blank or unresponsive states, operational controls reachable at four viewports, forced colors preserving control boundaries and keyboard focus, and reduced motion disabling loader and drawer animation. Nothing ever ran it. The suite sits behind `nx e2e cockpit`, and the cockpit-e2e matrix only dispatches caps derived from walking cockpit/** — apps/cockpit is never a candidate. No other job named the target either: grepping every workflow for `nx e2e` returns examples-chat-angular, examples-ag-ui-angular, the cap matrix, and website. So this has been dead coverage for its whole life. Verified it actually passes before wiring it up — 7/7 in 24s locally. It goes in the existing `cockpit` job rather than a new one because it is cheap, it reuses that job's `npm ci`, the `cockpit` scope already gates the shell, and required-pr-checks already aggregates the job — so it becomes merge-blocking with no gate change. The playwright config already sets retries: 2 on CI. Found while auditing the tags I removed from apps/cockpit in #939. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
blove
added a commit
that referenced
this pull request
Sep 2, 2026
) #921 added apps/cockpit/e2e/control-plane.spec.ts — 7 Playwright tests over the operational sidebar: the real Angular handshake without blank or unresponsive states, operational controls reachable at four viewports, forced colors preserving control boundaries and keyboard focus, and reduced motion disabling loader and drawer animation. Nothing ever ran it. The suite sits behind `nx e2e cockpit`, and the cockpit-e2e matrix only dispatches caps derived from walking cockpit/** — apps/cockpit is never a candidate. No other job named the target either: grepping every workflow for `nx e2e` returns examples-chat-angular, examples-ag-ui-angular, the cap matrix, and website. So this has been dead coverage for its whole life. Verified it actually passes before wiring it up — 7/7 in 24s locally. It goes in the existing `cockpit` job rather than a new one because it is cheap, it reuses that job's `npm ci`, the `cockpit` scope already gates the shell, and required-pr-checks already aggregates the job — so it becomes merge-blocking with no gate change. The playwright config already sets retries: 2 on CI. Found while auditing the tags I removed from apps/cockpit in #939. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Actual VoiceOver was not available for this pass; semantic accessibility, keyboard behavior, forced colors, and reduced motion are covered.