chore(mobile,plugin): adopt very_good_analysis lint preset - #70
Merged
Conversation
Replace flutter_lints with very_good_analysis across mobile app, ferrostar_flutter plugin, and example. Plugin treated as a published library (public_member_api_docs enforced); mobile and example disable docs lint and lines_longer_than_80_chars (dart format is authoritative). Fixes 0 → 0 issues across all three packages. ~509 lints fixed: - 454 auto-fixed by dart fix --apply in mobile - 55 auto-fixed in plugin - ~219 manual fixes in mobile (Dio type args, unawaited/discarded futures, on Object catches, cascade rewrites, dynamic casts, etc.) - ~95 manual fixes in plugin + example (full public API doc comments, pubspec sorting, escaped html in doc comments, line breaks) All tests pass: 177/177 mobile, 21/21 plugin, 1/1 example.
…136862 # Conflicts: # mobile/lib/models/user.dart # mobile/lib/providers/route_provider.dart # mobile/lib/screens/map_screen.dart # mobile/lib/widgets/map/route_sheet.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flutter_lints→very_good_analysisin mobile app, ferrostar_flutter plugin, and plugin examplepublic_member_api_docsenforced — every public class/method/field gets a///docpublic_member_api_docs(apps, not libs) andlines_longer_than_80_chars(dart format is authoritative)Lint cleanup
flutter analyzeis now 0 issues across all three packages.Roughly 509 lints fixed in total: ~509 from
dart fix --apply, ~314 by hand. Substantive changes (not just style):inference_failure_*— added explicit type args to all Dio calls (<dynamic>since responses navigate.data); explicit generics on collection literals andFuture.delayed/MaterialPageRoute/etc.unawaited_futures/discarded_futures— wrapped fire-and-forget calls withunawaited(); converted some sites to async/await where propagation was correctavoid_catches_without_on_clauses—catch (e)→on Object catch (e)(semantically identical, lint-explicit)avoid_dynamic_calls— addedas Map<String, dynamic>casts before key accesscascade_invocations— rewrote repeated-receiver call sequences as cascade chainsavoid_positional_boolean_parameters—SetWakelocktypedef now takes a namedenabled:param;setDimmed(controller, enabled:)updated///docs on every public symbol inlib/src/(controller, exceptions, platform interface, method-channel platform, 8 freezed models)unintended_html_in_doc_comment— escaped<...>in doc comments using backticksTest plan
flutter analyzeclean in mobile, plugin, examplejust test-mobile— 177/177 passjust test-ferrostar-flutter-plugin— 21/21 pass