Skip to content

fix(ContextualMenuDropdown): responsiveness when vertical space is low - #1443

Open
kimanhou wants to merge 1 commit into
canonical:mainfrom
kimanhou:WD-39555-multi-select-responsiveness
Open

kimanhou wants to merge 1 commit into
canonical:mainfrom
kimanhou:WD-39555-multi-select-responsiveness

Conversation

@kimanhou

Copy link
Copy Markdown
Contributor

Done

  • ContextualMenuDropdown: change calculations of height

QA

Pinging @canonical/react-library-maintainers for a review.

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Steps for QA.

Percy steps

  • List any expected visual change in Percy, or write something like "No visual changes expected" if none is expected.

Fixes

Fixes: https://warthogs.atlassian.net/browse/WD-39555

Signed-off-by: Kim Anh Nguyen <4783194+kimanhou@users.noreply.github.com>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR seem not to address the problem correctly. I used the storybook and inserted a div with a top margin to force the situation we experienced in lxd-ui. The full option list is still not accessible. See the test video below.

Screencast.from.2026-10-13.08-03-03.webm

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants