Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/SegmentedControl/SegmentedControl.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export const Default: Story = {
sharable, reusable, tiny applications called Charmed Operators.
</p>
),
onClick: () => console.log("OLM clicked"),
},
{
label: "SDK",
Expand All @@ -35,6 +36,7 @@ export const Default: Story = {
them as Charms.
</p>
),
onClick: () => console.log("SDK clicked"),
},
{
label: "Charmhub",
Expand Down
36 changes: 36 additions & 0 deletions src/components/SegmentedControl/SegmentedControl.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,42 @@ describe("SegmentedControl", () => {
);
});

it("calls a segment onClick handler when clicked", async () => {
const user = userEvent.setup();
let currentTarget: HTMLButtonElement | null = null;
const onClick = jest.fn((event: React.MouseEvent<HTMLButtonElement>) => {
currentTarget = event.currentTarget;
});

render(
<SegmentedControl
segments={[
{
label: "label1",
content: <p>content1</p>,
},
{
label: "label2",
content: <p>content2</p>,
onClick,
},
]}
/>,
);

await user.click(screen.getByRole("tab", { name: "label2" }));

expect(onClick).toHaveBeenCalledTimes(1);
expect(currentTarget).toBe(screen.getByRole("tab", { name: "label2" }));
expect(screen.getByRole("tab", { name: "label2" })).toHaveAttribute(
"aria-selected",
"true",
);
expect(screen.getByRole("tabpanel", { name: "label2" })).toHaveTextContent(
"content2",
);
});

it("uses a roving tab index", () => {
render(
<SegmentedControl
Expand Down
10 changes: 9 additions & 1 deletion src/components/SegmentedControl/SegmentedControl.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ export type Segments = {
* Icon to be displayed alongside the label of the segment.
*/
iconName?: ValueOf<typeof ICONS> | string;
/**
* Callback function to be called when the segment is clicked.
*/
onClick?: React.MouseEventHandler<HTMLButtonElement>;
};

export type Props = {
Expand Down Expand Up @@ -112,6 +116,7 @@ const SegmentedControl = ({
>
{segments.map((segment, i) => {
const tabId = `${id}-tab-${i}`;
const onClick = segment.onClick;
return (
<button
aria-selected={activeIndex === i}
Expand All @@ -120,7 +125,10 @@ const SegmentedControl = ({
role="tab"
key={segment.label}
id={tabId}
onClick={() => setActiveIndex(i)}
onClick={(event) => {
setActiveIndex(i);
onClick?.(event);
}}
onKeyDown={(event) => handleSegmentKeyDown(event, i)}
ref={(element) => {
tabRefs.current[i] = element;
Expand Down
Loading