Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
dangerouslySetInnerHTMLfromChipand from theFilterPanelSectionheading.highlightSubStringnow returns React nodes with real<strong>elements for matches, sosubStringemphasis still works while values are rendered as text rather than parsed as HTML. An empty substring now reportsmatch: false; every caller already guards against an empty search term.Before / after
https://www.loom.com/share/7ed1536ead724322bed8de413f9a82b9
Before: When HTML is entered into the value input box, the output should render it as HTML instead of displaying it as plain text.
QA
Pinging @canonical/react-library-maintainers for a review.
QA steps
yarn docs, open Chip -> Default, setvalueto<b>bold</b>in Controls: it renders as plain text.yarn testandyarn lintpass.Percy steps
One new snapshot for the Chip "Substring highlight" story. No changes to existing stories expected.
Fixes
Fixes: #1091