Repository navigation
Conversation
|
As noted previously, the Screen.Recording.2026-10-21.at.9.58.06.PM.mov |
There was a problem hiding this comment.
🟡 Changes recommended
One or more issues must be addressed before approval.
1 open issue
What changed in this PR
Adds optional non-dismissable toast support across single and list views.
Changes:
- Adds the
dismissablenotification flag and helper arguments. - Hides individual dismiss buttons and excludes non-dismissable items from bulk dismissal.
- Adds Storybook and component tests.
| File | Description |
|---|---|
| src/components/Notifications/ToastNotification/ToastNotificationProvider.tsx | Updated as part of this pull request. |
| src/components/Notifications/ToastNotification/ToastNotificationList.tsx | Updated as part of this pull request. |
| src/components/Notifications/ToastNotification/ToastNotification.tsx | Updated as part of this pull request. |
| src/components/Notifications/ToastNotification/ToastNotification.test.tsx | Updated as part of this pull request. |
| src/components/Notifications/ToastNotification/ToastNotification.stories.tsx | Updated as part of this pull request. |
Review effort: Lite
Ninfa-Jeon
left a comment
There was a problem hiding this comment.
Some whitespace can be removed from tests and one suggestion to retain functionality. Triggering copilot review once again as I have some doubts regarding another code block.
|
🎉 This PR is included in version 4.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |

Done
dismissable?: booleanfield toToastNotificationTypeToastNotification(the floating single toast) no longer renders a dismiss button whendismissableisfalse.ToastNotificationList(the expanded list view) no longer renders a dismiss button for individual non-dismissable notifications, and excludes them from the "Dismiss all"/"Dismiss N" bulk action.QA
Pinging @canonical/react-library-maintainers for a review.
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-componentsrun:Install the resulting tarball in your project with:
QA steps
yarn startto launch StorybookToastNotificationstoryPercy steps
Fixes
Fixes: # .