fix: report unreadable files with an actionable error message - #208
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves resiliency when reading bundle files by converting common filesystem read failures (e.g. deleted/locked files between directory enumeration and open) into a user-friendly UserError, and updates manifest generation + Live Updates upload to use the new helper.
Changes:
- Add
readFileFromDirectory()wrapper that convertsEACCES,EBUSY,ENOENT,EPERMinto an actionableUserError. - Use
readFileFromDirectory()ingenerateManifestJson()and the Live Updates bundle upload loop. - Add initial unit tests for
readFileFromDirectory().
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/utils/manifest.ts | Switch manifest hashing to read files via readFileFromDirectory() for friendlier failures. |
| src/utils/file.ts | Introduce readFileFromDirectory() and map common unreadable-file errors to UserError. |
| src/utils/file.test.ts | Add unit tests around readFileFromDirectory() behavior. |
| src/commands/apps/liveupdates/upload.ts | Use readFileFromDirectory() when reading files during upload. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generateManifestJson()and the bundle upload loop enumerate a directory first and open every listed file afterwards. If a file vanishes or gets locked in between — e.g. a build still writing todist, or a file sync client — the rawENOENTsurfaced as an unexpected crash and got reported to Sentry (CAPAWESOME-TEAM-CLI-1P).readFileFromDirectory()now reads those files and turnsEACCES,EBUSY,ENOENTandEPERMinto aUserErrorthat names the affected file and hints at the likely cause. Any other error still propagates unchanged.