fix min/max variadic fold#1
Open
frewsxcv wants to merge 1 commit into
Open
Conversation
The fold expression `(r = std::min(arg0, args)), ...` compared `arg0` against each successive `args` element instead of folding through `r`, so for three or more arguments the result was `min(arg0, last_arg)` rather than the true minimum. e.g. `min(5, 3, 7)` returned 5. The single-argument overload (empty parameter pack) returned `r` without ever assigning it — undefined behavior. Initialize `r = arg0` and fold through `r`. Same fix for `maxv`.
Contributor
|
Hi @frewsxcv Thank you for the PR, and apologies for the late response. We are still in the process of sorting out some details around contribution guidelines and PR templates. The fix itself looks good; we'll merge it as soon as we figure out the problems on our end. I will get back to you once we are in a position to accept contributions. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fold expression
(r = std::min(arg0, args)), ...comparedarg0against each successiveargselement instead of folding throughr, so for three or more arguments the result wasmin(arg0, last_arg)rather than the true minimum. e.g.min(5, 3, 7)returned 5.The single-argument overload (empty parameter pack) returned
rwithout ever assigning it — undefined behavior.Initialize
r = arg0and fold throughr. Same fix formaxv.