Keep reports from all completed inputs - #801
Merged
Merged
Conversation
vfusco
requested review from
mpolitzer and
renatomaia
and
a balanced review from Copilot
October 2, 2026 00:43
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
It changes cross-layer persistence and replay semantics while introducing high-volume PostgreSQL COPY behavior requiring final human validation.
Review effort: Balanced
Findings: None
What changed in this PR
Persists reports for all completed inputs, exposes them through APIs, and verifies them during full replay.
Changes:
- Retains reports from rejected and terminal inputs.
- Uses PostgreSQL COPY for large report/output sets.
- Expands repository, replay, API, and integration coverage.
| File | Description |
|---|---|
test/integration/terminal_machine_states_test.go |
Clarifies report expectation. |
test/integration/lifecycle_test.go |
Verifies report persistence and API reads. |
test/integration/echo_authority_test.go |
Checks inspect report payload. |
test/integration/cli_helpers_test.go |
Adds filtered and single-report helpers. |
internal/repository/repotest/report_test_cases.go |
Updates report-filter assumptions. |
internal/repository/repotest/report_filter_test_cases.go |
Tests completed-status report queries. |
internal/repository/repotest/nonaccepted_reports_test_cases.go |
Tests rejected and large report sets. |
internal/repository/repotest/bulk_test_cases.go |
Covers nonaccepted report persistence. |
internal/repository/repotest/advance_evidence_test_cases.go |
Tests large COPY payloads and rollback. |
internal/repository/replay.go |
Documents full replay semantics. |
internal/repository/postgres/report.go |
Includes nonaccepted reports in epoch queries. |
internal/repository/postgres/replay_source_test.go |
Covers rejected reports in replay pages. |
internal/repository/postgres/copy_cancellation_test.go |
Tests COPY cancellation handling. |
internal/repository/postgres/bulk.go |
Implements COPY persistence and all-status reports. |
internal/repository/postgres/bulk_test.go |
Verifies schema-qualified COPY targets. |
internal/replay/run_test.go |
Adds reports to replay executor fixtures. |
internal/replay/report_test.go |
Tests nonaccepted and legacy replay reports. |
internal/replay/compare.go |
Compares reports for every completed input. |
internal/replay/compare_test.go |
Expands completion-matrix coverage. |
internal/manager/invalid_outputs_root_test.go |
Verifies terminal report retention. |
internal/manager/instance.go |
Preserves reports across completion statuses. |
internal/manager/instance_test.go |
Tests rejected and terminal reports. |
internal/advancer/invalid_outputs_root_test.go |
Verifies invalid-root report persistence. |
internal/advancer/determinism_test.go |
Includes reports in determinism checks. |
internal/advancer/advancer_test.go |
Covers report propagation through advancing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vfusco
added this pull request to stack #802
October 2, 2026 00:58
mpolitzer
previously approved these changes
Oct 2, 2026
vfusco
dismissed
mpolitzer’s stale review
October 2, 2026 17:36
The merge-base changed after approval.
renatomaia
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep reports from accepted, rejected, and terminal inputs. Include these reports in API queries and Full replay checks. Use PostgreSQL COPY to store large output and report sets.