fix: compatibility with agent-shell v0.73.4 - #4
Open
mwmcarney wants to merge 8 commits into
Open
Conversation
Replace removed private functions with their current equivalents: - agent-shell--enqueue-request -> agent-shell--prompt-queue-enqueue - agent-shell--process-pending-request -> agent-shell--prompt-queue-process-next - shell-maker--busy (variable) -> shell-maker-busy (public function) - agent-shell-diff :old/:new/:file kwargs -> :diffs list-of-alists Replace shell-maker-finish-output-hook with a per-buffer agent-shell-subscribe-to :event turn-complete subscription for queue draining -- scoped to the dispatcher buffer only. Add forward declarations for remaining private API dependencies and agent skills configuration files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The define-globalized-minor-mode macro references its second argument as a variable at expansion time. The defvar must precede the macro call. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add agent-shell-dispatch-wayfinder.el, a bridge that connects wayfinder skill efforts to the dispatch SVG task graph. Supports two tracker backends: - Local markdown (.scratch/<effort>/issues/) — the default - GitHub Issues (via `gh` CLI with wayfinder:* labels) The bridge parses tickets and blocking edges into dispatch task nodes, handles fog-of-war (incremental add/remove as tickets are graduated/scoped-out), and syncs statuses as tickets are claimed/resolved. New public API in agent-shell-dispatch.el: - agent-shell-dispatch-add-task: insert/replace a single node - agent-shell-dispatch-add-tasks: batch insert with one rebuild - agent-shell-dispatch-remove-task: remove node + clean dangling edges These enable the wayfinder bridge to grow/shrink the graph without restarting the full dispatch session (preserving subscriptions, timers, agent registrations, and accumulated statuses). README updated with wayfinder integration section including the CLAUDE.md/AGENTS.md snippet users should add to wire up the lifecycle hooks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Extract dispatch state structs and status resolution into agent-shell-dispatch-state.el (was untracked, causing load failure on fresh Emacs starts via elpaca). Add comprehensive integration test suite (34 tests) verifying end-to-end interaction between dispatch, render, messages, and wayfinder modules. Fix two pre-existing test failures where shell-maker-busy stub was not bound during working-state assertions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add wayfinder auto-start: when a ticket's blockers are all done, it starts automatically. Works on initial load and cascades through the graph via turn-complete subscriptions on subagent buffers. - Gate permission rendering in dispatcher behind feature variable `agent-shell-dispatch-msg-show-permissions-in-dispatcher` (default nil). SVG lock icon still shows regardless; native permission UI displays in the subagent's own buffer when the feature is off. - Fix sync-statuses to never downgrade working/done back to claimed/waiting from file state. - Prune stale permissions every render cycle via build-status-map. - Add CLAUDE.md dispatch commands section teaching agents how to interact with the dispatch system via emacsclient. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-shell--prompt-queue-enqueue,agent-shell--prompt-queue-process-next,shell-maker-busy)shell-maker-finish-output-hookwith a scopedagent-shell-subscribe-to :event turn-completesubscription for queue drainingdefine-globalized-minor-modereferenced its dummy variable before it was definedTest plan
(require 'agent-shell-dispatch)loads without errorsagent-shell-dispatch-start-currentregisters a task graph and renders SVG headeragent-shell-dispatch-reporttransitions nodes through working/done statesagent-shell-dispatch-stoptears down cleanlyagent-shell-dispatch-spawn-agentcreates background agent buffers🤖 Generated with Claude Code