fix(deps): use iced_core for color conversions - #80
Open
JosephDemarest wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iceddependency withiced_core, which owns the convertedColorandBackgroundtypesicedas a dev dependency so the existing GUI example still compiles and exercises the conversionsicedfeature while avoiding renderer, windowing, and executor defaults for downstream usersThe normal/build dependency graph for
--no-default-features --features iceddrops from 206 unique packages to 33 (173 fewer, 83.98%).Closes #77
Verification
cargo check --no-default-features --features iced --libcargo check --example iced --features icedcargo build --features "ansi-term bevy css-colors iced ratatui serde" --verbosecargo test --features "ansi-term bevy css-colors iced ratatui serde" --verbosecargo fmt --all --checkcargo check --all-targets --all-featurescargo package --allow-dirtyuvx pre-commit run --all-filesreaches an existing Rust 1.97 Clippy failure inbuild.rs:212(iter_kv_map), reproduced unchanged onorigin/main. All other hooks pass for the changed files.