Preserve configuration when copying ConfigBox - #325
Open
oyeong011 wants to merge 2 commits into
Open
Conversation
Tested: 163 tests passed; copy and copy.copy public API QA Confidence: high Scope-risk: moderate Directive: Copies retain the concrete Box subclass and detach their namespace.
Constraint: Generic Box subclasses retain the existing Box return type, including subclasses with required constructor arguments. Rejected: Constructing type(self) in Box.copy | breaks incompatible subclass constructors Tested: 169 tests passed; public copy and copy.copy subclass/namespace QA Confidence: high Scope-risk: narrow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying a ConfigBox currently discards options such as frozen_box and default_box, so a frozen copy becomes writable and default-value lookups stop working.
Preserve the ConfigBox configuration while excluding internal bookkeeping and detaching its namespace. Generic Box.copy keeps its existing behavior, including for subclasses with required constructor arguments; ConfigBox subclasses still copy to ConfigBox.
Validation: 169 tests passed on Python 3.14, including copy/copy.copy frozen/default regressions, constructor compatibility, namespace detachment and internal-key exclusion. Public API QA also passes. Cython and the remaining interpreter matrix were not run.
AI assistance: OpenAI Codex prepared the change and regression tests.