Skip to content

fix(ci): make artifactory delivery non-blocking - #6507

Open
Nivoky wants to merge 1 commit into
developfrom
MON-212449-ci-artifactory-non-blocking
Open

Nivoky wants to merge 1 commit into
developfrom
MON-212449-ci-artifactory-non-blocking

Conversation

@Nivoky

@Nivoky Nivoky commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Description

Artifactory is only a backup of the Pulp delivery and is about to be shut down. Until now, an unreachable Artifactory or an invalid token failed the deliver-packages jobs, turned the runs red and skipped the jobs depending on them (set-skip-label, nightly Jira ticket).

  • A new check-artifactory action probes Artifactory with the token; the Artifactory steps of package-delivery (used by the 12 delivery workflows) only run when it answers.
  • When it does not, the jobs stay green with a single warning naming the cause (empty token, token rejected, host unreachable), also written to the run summary. Pulp delivery is not affected.
  • With a valid token, the double run is unchanged. An Artifactory error after a successful probe still fails the job, as today.

Fixes MON-212449

Relates to: centreon/centreon#12093

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Feature branches are delivered as canary, so delivery only runs after merge:

  1. Valid token: run plink.yml with workflow_dispatch on develop (3 RPMs): the probe reports Artifactory available and the packages still reach Artifactory unstable.
  2. Fake token: set a repo-level secret ARTIFACTORY_ACCESS_TOKEN to a fake value (it applies to every run of the repository, so keep it short) and run plink.yml again: the deliver jobs are green with an "Artifactory unavailable" warning, the Pulp jobs and set-skip-label run as usual. Delete the secret afterwards.
  3. Testing and stable: check the next release-*/hotfix-* push and the next plugins tag the same way.

Checklist

  • I have rebased my development branch on the base branch (develop).

🤖 Generated with Claude Code

Artifactory is only kept as a backup of the Pulp delivery and is about
to be shut down. Until now, an unreachable Artifactory or an invalid
token failed the deliver-packages jobs, which turned the run red and
skipped the jobs depending on them.

The new check-artifactory action probes Artifactory once at the start
of package-delivery. When it does not answer (empty or rejected token,
unreachable host, unexpected HTTP status), the jfrog setup, clean,
download-from-testing and publish steps are skipped with a single
warning naming the cause, and the Pulp delivery jobs are not affected.
With a valid token, the double run is unchanged.

Refs: MON-212449

Assisted-by: Claude Code (claude-opus-5-5)
@Nivoky Nivoky added ai-reviewed Pull request that already went through an AI-assisted review (e.g. via the check-pr skill). area/ci enhancement Enhance existing labels Oct 16, 2026
@Nivoky
Nivoky marked this pull request as ready for review October 16, 2026 16:26
@Nivoky
Nivoky requested a review from a team as a code owner October 16, 2026 16:26
@Nivoky
Nivoky requested review from Tpo76 and pkriko and removed request for a team October 16, 2026 16:26

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-reviewed Pull request that already went through an AI-assisted review (e.g. via the check-pr skill). area/ci enhancement Enhance existing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant