sqlalchemy v2 - #150
Open
zmc wants to merge 11 commits into
Open
sqlalchemy v2#150zmc wants to merge 11 commits into
zmc wants to merge 11 commits into
Conversation
zmc
force-pushed
the
update-deps
branch
4 times, most recently
from
July 7, 2026 00:18
b288374 to
4ed984f
Compare
Also: - update pecan - update psycopg to v3 - drop statsd Signed-off-by: Zack Cerza <zack@cerza.org>
Signed-off-by: Zack Cerza <zack@cerza.org>
Signed-off-by: Zack Cerza <zack@cerza.org>
This endpoint's logic was a little strange and was also implemented as requiring a POST request. Simplify it and correct its behavior. Also fix a test bug. Signed-off-by: Zack Cerza <zack@cerza.org>
Before: * Used global thread-scoped sessions * Sessions could leak between requests causing incorrect updates * Tests were difficult to get right After: * Request-scoped sessions that are isolated from each other * Lifecycle managed in one place * Guaranteed cleanup on error * Tests are more terse and easily understood * Pytest fixtures which make tests composable and more maintainable * Tests do not persist any state to the database * Eaasy to invoke integration tests Signed-off-by: Zack Cerza <zack@cerza.org>
zmc
marked this pull request as ready for review
July 13, 2026 21:26
Signed-off-by: Zack Cerza <zack@cerza.org>
* Update python and actions versions * We don't use travis or nose Signed-off-by: Zack Cerza <zack@cerza.org>
Signed-off-by: Zack Cerza <zack@cerza.org>
This lets us simplify error handling in controllers, and to avoid ever returning HTML inadvertently Signed-off-by: Zack Cerza <zack@cerza.org>
Run the full test suite with a live paddles server backed by an ephemeral PostgreSQL service container so race and HTTP integration tests execute in CI. Signed-off-by: Zack Cerza <zack@cerza.org>
This fixes failures that I only saw in GitHub Actions Signed-off-by: Zack Cerza <zack@cerza.org>
Contributor
|
Working on reviewing this ASAP |
Contributor
|
I didn't want to interfere with your branch so I made a new one, rebased on main, and fixed a few regressions. #153 Tested end to end on an exact copy of today's paddles database. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.