Skip to content

ENT-10199: Fixed a bug where some functions would not understand current namespace #6213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SimonThalvorsen wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

ENT-10199: Fixed a bug where some functions would not understand current namespace #6213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion libpromises/fncall.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ Rlist *NewExpArgs(EvalContext *ctx, const Policy *policy, const FnCall *fp, cons
return RlistCopy(fp->args);
}

assert(fp != NULL);

const FnCallType *fn = FnCallTypeGet(fp->name);
if (fn == NULL)
{
Expand Down Expand Up @@ -101,7 +103,9 @@ Rlist *NewExpArgs(EvalContext *ctx, const Policy *policy, const FnCall *fp, cons
}
else
{
rval = ExpandPrivateRval(ctx, NULL, NULL, rp->val.item, rp->val.type);
const Bundle *caller_bundle = fp->caller ? PromiseGetBundle(fp->caller) : NULL;
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
const char *caller_ns = caller_bundle ? caller_bundle->ns : NULL;
rval = ExpandPrivateRval(ctx, caller_ns, NULL, rp->val.item, rp->val.type);

@olehermanse olehermanse Jul 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is scope / bundle NULL here? If that is indeed correct, it deserves a comment.

assert(rval.item);
}

Expand Down
Loading