Repository navigation
Fix: Warn when a named course matches no build folder (fixes #92) - #93
Merged
Merged
Conversation
oliverfoster
approved these changes
Oct 7, 2026
oliverfoster
left a comment
Member
There was a problem hiding this comment.
Ran Tasks.filterOutputDirs with rub's own modules against a layout of m05-mycourse and p101:
| course names | output | returns |
|---|---|---|
m05 |
"No course found matching: m05" / "Available courses: m05-mycourse, p101" | null (unchanged) |
m05-mycourse |
none | that course |
| none | none | all courses |
m05, empty builds folder |
"No course found matching: m05" / "No courses were found in this folder." | null |
The destructured warn/notice are safe to call detached, since Logger's static methods reference Logger rather than this.
|
🎉 This PR is included in version 1.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #92
Fix
m05againstm05-mycourseis obvious from the output.Tasks.filterOutputDirsalready detected this case and returnednull; it just never said anything. The warning goes in at that point, before thenullis returned, so the existing control flow is unchanged.Testing
Open an Adapt folder whose builds/ directory holds at least one course, e.g.
m05-mycourseandp101.Run
rub -ds m05. Expect:Run
rub -ds m05-mycourse. Expect the build and server to run as before, with no warning.Run
rub -dswith no course name. Expect all courses to build as before, with no warning.Posted via collaboration with Claude Code