deploy: chown release to root so files are not owned by the runner uid 1001

[chaoming0625]

Deploys leave files on the VPS owned by uid/gid 1001 (the GitHub runner's user). Finding from the remote.chaobrain.com hub, record 393 (prod uid 1001 / needrestart orphans).

Cause: appleboy/scp-action packs the files into a tarball on the runner and unpacks it on the server with plain tar -zxf. These deploys log in as root, and GNU tar running as root keeps the owner stored in the archive (--same-owner is the default for root). So every file in the release ends up owned by 1001:1001. The admin deploy also runs its own tar -xzf as root, with the same result.

On the VPS, uid 1001 no longer maps to any account since the cbl-release account was removed. gid 1001 is hubclient, a legacy hub group. Files owned by them are orphans, and they show up in the hub's audits.

Fix: make the files owned by the user that deploys (root).

• scp-action uploads: chown -R root:root "$release" in the activate step, before the symlink swap. scp-action has no option to pass --no-same-owner to the remote tar, because its tar_exec input is also used as the local binary name.
• the admin's own untar (chaobrain.com only): tar --no-same-owner -xzf.

Nothing else changes. Merging triggers a production deploy, so a human should merge this.

Summary by Sourcery

Ensure documentation deployments leave release files owned by root to prevent orphaned runner ownership on the VPS.

Bug Fixes:

• Ensure uploaded documentation releases are owned by root instead of retaining the GitHub runner's orphaned uid/gid.

Deployment:

• Correct release ownership during the documentation deployment before switching the active release.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The deployment workflow now corrects ownership on each scp-action-uploaded release before the symlink swap, preventing runner uid/gid 1001 from leaving orphaned files on the VPS; the described admin untar change is not present in the provided diff.

Sequence diagram for root-owning uploaded releases

sequenceDiagram
    participant Runner as GitHub Runner
    participant SCP as scp-action
    participant VPS as VPS
    participant Deploy as Deploy Workflow

    Runner->>SCP: Upload release archive
    SCP->>VPS: tar -zxf release archive
    VPS-->>VPS: Release files owned by uid/gid 1001
    Deploy->>VPS: chown -R root:root release
    Deploy->>VPS: ln -sfn release current.next
    Deploy->>VPS: mv -Tf current.next current

Loading

File-Level Changes

Change	Details	Files
Ensure uploaded document releases are owned by root before activation.	Recursively chown the newly unpacked release to root:root after validating its index file. Perform the ownership correction before updating the current-release symlink.	.github/workflows/deploy-docs.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook