Repository navigation
Conversation
Primarily useful for subqueries built from another `DatabaseSource`.
```php
$articles = $this->getArticleRepository()->source();
$categories->addFilter([
'condition' => sprintf('objTable.`id` IN (%s)', $articles->sqlLoad()),
'binds' => $articles->filterBinds(),
]);
```
Introduced in v5.1.5, a Filter’s binds are reset and rebuilt only when `DatabaseFilter::sql()` is called.
This commit rearranges the logic to preserve a Filter’s predefined binds if its an active Condition or inactive. Otherwise, reset and rebuild the binds form the sub-Filters or Fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primarily useful for subqueries built from another
DatabaseSource.Previously, a Filter’s binds are reset and rebuilt only when
DatabaseFilter::sql()is called.This proposal rearranges the logic to preserve a Filter’s predefined binds if the Filter is an active Condition or the Filter is inactive. Otherwise, reset and rebuild the binds form the sub-Filters or Fields.