Repository navigation
FIX: Indexing bug of (physical) surfaces to account for all walls - #42
Merged
Merged
Conversation
just the first one
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues in the focused fix and regression test; runtime tests were not executed.
No open issues 🎉
What changed in this PR
Fixes room geometry import so physical groups spanning multiple surfaces contribute all their walls.
Changes:
- Collects mesh face nodes from every surface in each physical group instead of only the first.
- Adds a regression test verifying that merging surfaces into one physical group preserves the wall count.
| File | Description |
|---|---|
pyroomacoustics_method/tests/test_pyroomacoustics_backend.py |
Adds wall-count regression coverage for multi-surface groups. |
pyroomacoustics_method/pyroomacoustics_interface/pyroomacoustics_interface.py |
Imports face nodes from all surfaces within each physical group. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of physical surface groups in the room geometry import process and adds a corresponding test to ensure correctness. It adds support for physical groups that span multiple surfaces.
_import_room_geometrymethod inpyroomacoustics_interface.pyto support physical groups (materials) that span multiple surfaces, ensuring all surfaces in a group are processed, not just the first one.test_import_room_geometry_multi_surface_groupintest_pyroomacoustics_backend.pyto verify that all surfaces of a physical group are imported as walls, not just the first, and that merging surfaces into a single group maintains the correct wall count.