Skip to content

FIX: Indexing bug of (physical) surfaces to account for all walls - #42

Merged
mberz merged 1 commit into
mainfrom
fix/pyroomacoustics/skipped_walls
Oct 26, 2026
Merged

mberz merged 1 commit into
mainfrom
fix/pyroomacoustics/skipped_walls

Conversation

@mberz

@mberz mberz commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

This pull request improves the handling of physical surface groups in the room geometry import process and adds a corresponding test to ensure correctness. It adds support for physical groups that span multiple surfaces.

  • Updated the _import_room_geometry method in pyroomacoustics_interface.py to support physical groups (materials) that span multiple surfaces, ensuring all surfaces in a group are processed, not just the first one.
  • Added a new test test_import_room_geometry_multi_surface_group in test_pyroomacoustics_backend.py to verify that all surfaces of a physical group are imported as walls, not just the first, and that merging surfaces into a single group maintains the correct wall count.

@mberz mberz added this to the v0.1.1 milestone Oct 26, 2026
@mberz mberz added the bug Something isn't working label Oct 26, 2026
@mberz
mberz requested a balanced review from Copilot October 26, 2026 09:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Static review found no blocking issues in the focused fix and regression test; runtime tests were not executed.

No open issues 🎉

What changed in this PR

Fixes room geometry import so physical groups spanning multiple surfaces contribute all their walls.

Changes:

  • Collects mesh face nodes from every surface in each physical group instead of only the first.
  • Adds a regression test verifying that merging surfaces into one physical group preserves the wall count.
File Description
pyroomacoustics_method/​tests/​test_pyroomacoustics_backend.py Adds wall-count regression coverage for multi-surface groups.
pyroomacoustics_method/​pyroomacoustics_interface/​pyroomacoustics_interface.py Imports face nodes from all surfaces within each physical group.

Review effort: Balanced

@mberz mberz modified the milestones: v0.1.1, pyroomacoustics-v0.1.1 Oct 26, 2026
@mberz
mberz merged commit 3afea2b into main Oct 26, 2026
23 of 25 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in CHORAS planning Oct 26, 2026
@mberz
mberz deleted the fix/pyroomacoustics/skipped_walls branch October 26, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants