Repository navigation
fix: ignore a value set again by the host - #32
Merged
Merged
Conversation
Vue sets the value property of a custom element on every render of its parent. With the store kept per element, the host's initial value was applied again when the editor was closed, erasing the user's changes. Only a new string value replaces the content now, 0.1.x ignored every value after the first one. The compatibility page sets the value again on every toggle, like Vue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while checking the Ciklik app (Vue 3 host) against main: Vue patches the
valueproperty of a custom element on every render of its parent, with the same initial string. Since the store now lives as long as the element, closing the editor applied the initial value again and erased the user's changes.The element now ignores a string value equal to the last one set by the host; a different value still replaces the content (0.1.x ignored every value after the first one).
server/compat.htmlnow sets the value again on every toggle like Vue does, and the "keeps the content" compatibility spec fails without the fix.