Repository navigation
fix: Example: Safe Mutation with Idempotent POST Requests - #68
Open
webbrain-one wants to merge 1 commit into
Open
webbrain-one wants to merge 1 commit into
webbrain-one wants to merge 1 commit into
Conversation
Demonstrate safe retries for state-changing requests by reusing a single idempotency key and retrying only 5xx statuses, not 4xx business-logic errors.
cinar
requested changes
Aug 20, 2026
cinar
left a comment
cinar
left a comment
Owner
There was a problem hiding this comment.
Thank you very much for your contribution! I added few minor comments. Please let me know what do you think.
| fmt.Println("\nUnexpected: terminal scenario succeeded instead of returning 400.") | ||
| } | ||
|
|
||
| func executeSafePOST(ctx context.Context, client *http.Client, url string, payload string, maxAttempts int) error { |
Owner
There was a problem hiding this comment.
The executeSafePOST declares maxAttempts as int but passes it directly to resile.WithMaxAttempts, which requires uint. Perhaps you can change it here as well?
| {"wrapped transport", fmt.Errorf("request failed: %w", errors.New("connection reset by peer")), true}, | ||
| {"500", &HTTPError{StatusCode: http.StatusInternalServerError}, true}, | ||
| {"502", &HTTPError{StatusCode: http.StatusBadGateway}, true}, | ||
| {"504", &HTTPError{StatusCode: http.StatusGatewayTimeout}, true}, |
Owner
There was a problem hiding this comment.
Is skipping 503 (Service Unavailable) intentional? Would you like to include it here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49