Lead the store screenshots with the dark theme - #297
Merged
Merged
Conversation
Most people use the dark theme, so the listing shows the numbered screens in it, starting with the now-playing screen and its album cover, then the light theme's player last, to show there is one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012foWs5vBJrYTDtfyFhJ3ky
Store screenshotsFrom run 36715858482, against clementine-it. Left: the store listing on master, which shows the dark theme. Right: this pull request, dark and light.
|
The listing now shows the dark theme first, and the light player after it, so the pull request comment pairs each listing image with the dark screen, next to it, and counts the light player when checking the run took them all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012foWs5vBJrYTDtfyFhJ3ky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most people use the dark theme, so the store listing now leads with it.
scripts/store_graphics.pybuilds the phone screenshots in this order:Play shows at most eight. The images are regenerated from the
store-screenshotsrun 36711908224. The icon and feature graphic are unchanged.The screenshot comment on pull requests (
scripts/post_screenshots.sh) now puts each of master's listing images next to the matching dark screen. In this PR's own comment, the master column still shows master's old light screenshots. Once this merges, master and the dark column line up.If #296 has merged by the time this does, its
play-listingworkflow sends the new screenshots to Play on the push tomaster. F-Droid reads them from the repository.🤖 Generated with Claude Code
https://claude.ai/code/session_012foWs5vBJrYTDtfyFhJ3ky