Send the store listing to Play's default language - #298
Merged
Merged
Conversation
Play's listing for the app isn't in en-US, so the first run on master failed: "Listing for language 'en-US' not found". The script now asks the edit for the app's default language and updates that listing, creating it if there's none yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012foWs5vBJrYTDtfyFhJ3ky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first
play-listingrun on master (run 36716472767) signed in and opened a Play edit. It then failed with:The script assumed the Play listing was
en-US, but the app's default language in Play Console is something else. The edit was deleted, so nothing changed on Play.scripts/play_listing.pynow:edits.details) and updates that listing;update) if Play has none in that language yet, and otherwise patches it as before, which keeps anything the script doesn't manage, such as a video;fastlane/metadata/android/en-US/stays the source. RELEASING.md now says where the listing goes on Play.Tested:
--checkstill passes on the listing. Against a fake Play API with default languageen-GBand no listing yet, the script created theen-GBlisting, uploaded the icon, the feature graphic and all 7 screenshots, and committed the edit. The next master run will test it against the real Play API.🤖 Generated with Claude Code
https://claude.ai/code/session_012foWs5vBJrYTDtfyFhJ3ky
Generated by Claude Code