Show music note for songs without cover art - #16
Merged
Merged
Conversation
Clementine sends its "no cover" picture, a jewel case that isn't square and was cropped, as the art of a song without a cover. The app now recognises it by the song's empty art_automatic and art_manual (or an art_manual of "(unset)") and drops it, as the Android remote does, so the player, the mini player, the song details and the lock screen show no cover for it. The artwork then shows a music note, as Android's does; the Clementine mark is left for when nothing's playing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015dJQ8hcp9Vd6tD9gJAXxTx
ScreenshotsFrom run 36698787369, against a real Clementine. Left: main. Right: this pull request, light and dark.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clementine sends its "no cover" picture (a jewel case) for songs without cover art, which the app now recognizes and filters out. Songs without covers now display a music note icon instead, matching the Android remote's behavior.
Key changes:
Song.hasCover(_:)method to detect Clementine's "no cover" picture by checking ifart_automaticandart_manualare both empty, or ifart_manualis "(unset)"Song.init(metadata:)to usehasCover()when deciding whether to keepartDataArtworkview to accept aSong?instead of justData?, allowing it to distinguish between "no song playing" (Clementine mark) and "song without cover" (music note)Artworkfor songs without covers, styled as 40% of the artwork size inon-surface-variantcolorArtworkcall sites inPlayerView,SongDetailsView, andMiniPlayerSongArtTestscovering automatic covers, manual covers, and the "(unset)" caseThe change ensures the app properly handles Clementine's "no cover" picture while maintaining visual consistency with the Android remote.
https://claude.ai/code/session_015dJQ8hcp9Vd6tD9gJAXxTx