Skip to content

Start Clementine without the remote streaming flag #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hatstand merged 1 commit into from
Sep 30, 2026
Merged

Start Clementine without the remote streaming flag #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions clementine-it/start-clementine.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@
# library and its playlist, for the screenshots (.github/workflows/screenshots.yml). Clementine
# runs in the background, logging to <log>; this returns once it's ready.
#
# Remote streaming is on ("Allow playing on remote devices", and --experimental-remote-streaming for
# releases before 1.4.1-238, which need it), so the app can offer to play on the phone, and the
# screenshots show where Clementine can play.
# Remote streaming is on ("Allow playing on remote devices"), so the app can offer to play on the
# phone, and the screenshots show where Clementine can play.
#
# start-clementine.sh <Clementine.app> <music dir> <log>
#
Expand Down Expand Up @@ -63,12 +62,7 @@ defaults write "$domain" SavedRadio.streams.3.name -string "Secret Agent"
defaults write "$domain" SavedRadio.streams.3.url -string http://ice1.somafm.com/secretagent-128-mp3
defaults write "$domain" SavedRadio.streams.size -int 3

# Later releases don't know the flag, and exit on options they don't know.
streaming=()
if grep -q -a experimental-remote-streaming "$binary"; then
streaming=(--experimental-remote-streaming)
fi
nohup "$binary" --verbose ${streaming[@]+"${streaming[@]}"} > "$log" 2>&1 &
nohup "$binary" --verbose > "$log" 2>&1 &
pid=$!
echo "$pid" > "$log.pid"
if ! wait_for "the network remote" "nc -z localhost 5500"; then
Expand Down
4 changes: 2 additions & 2 deletions design/DESIGN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,8 +410,8 @@ hidden while the app is active.

### Remote streaming

Clementine 1.4 with *Allow playing on remote devices* on (and, before 1.4.1-238, started with
`--experimental-remote-streaming`) can play on its remotes instead of its computer, as the Android remote does. The
Clementine 1.4 with *Allow playing on remote devices* on can play on its remotes instead of its
computer, as the Android remote does. The
protocol is Clementine's: `RENDER_*` messages to a renderer, `RENDERER_*` back, `OUTPUTS` to every
remote.

Expand Down
Loading