fix(task) #35 #36 #37 #38 #39 RequestTask and Client fixes, #31 add missing tests

[njoubert-cleverage]

Description

Fixes #31.
Fixes #35.
Fixes #36.
Fixes #37.
Fixes #38.
Fixes #39.

Grouped in one PR because the fixes change the same task, client, tests, reference pages and the CHANGELOG Latest section.

RequestTask

• RequestTask fails on a 3xx / 4xx status code declared in valid_response_code #35: once the status code is accepted, the content is read with getContent(false): a 3xx / 4xx / 5xx code listed in valid_response_code now outputs the response body (getContent() threw, the catch only skipped the log). The then useless exception filtering of the catch is removed: every failure is logged.
• RequestTask does not log transport errors #36: the response headers / body of the error log are read by getResponseDetails(), which returns nothing after a transport error (reading them threw again inside the catch: the log was lost).
• RequestTask log_response logs the configured url and the response object #37: log_response logs the requested URL (merged with the input) and status_code, headers, content instead of the configured url and the response object.
• RequestTask and Client fail with an unrelated TypeError on a non-array input or a non-string url parameter #38: a non-array input throws RequestTask expects an array or empty input, <type> given (TypeError from array_merge()).

Client

• RequestTask and Client fail with an unrelated TypeError on a non-array input or a non-string url parameter #38: scalar URL parameters are converted to strings (an int triggered a TypeError from rawurlencode()), a non-scalar one throws an \UnexpectedValueException.
• Client::geUri() typo, MissingClientException::create() typing #39: getUri() added, geUri() deprecated (PHPDoc only, it still works) in Client and ClientInterface: adding getUri() to the interface would break the custom clients, it is left for the next major version. MissingClientException::create(string $code): self.

Tests (#31)

• RequestTaskTest: body output, input overriding the options, 3xx / 4xx / 5xx codes declared valid, invalid code with skip / stop (error output, log with headers and body), transport error and error while reading the content (logged), log_response, non-array input, missing client.
• ClientTest: accessors (getUri() / geUri()), GET with query string and encoded scalar URL parameters, JSON POST, raw body and custom headers, invalid method, invalid URL parameters, unknown option, request failure.
• MissingClientExceptionTest, CleverAgeRestProcessExtensionTest, CleverAgeRestProcessBundleTest (new).

25 tests, 187/195 lines. The remaining lines are ClientRegistry and the compiler pass of the bundle, whose tests come with #34 (left out here to avoid conflicting files). Without the fix, 15 of the new tests fail.

Documentation: request_task.md (inputs, output, url_parameters, log_response, notes on valid codes and transport errors), client.md (URL parameters, geUri() deprecation, getApiUrl()).

Checked with process-bundle-demo (see the demo PR):

Process	Before	After
demo.rest.valid_client_error (400 declared valid)	HTTP/2 400 returned for ...	the response body is output
demo.rest.transport_error	no REST request failed log	logged, then Could not resolve host
demo.rest.log_response (-vvv, url from the input)	Response received from '/configured/url', result object	Response received from '/codes-postaux/communes/46800', status code / headers / content
demo.rest.url_parameter_int	rawurlencode(): Argument #1 ($string) must be of type string, int given	the response body is output
demo.rest.invalid_input	array_merge(): Argument #2 must be of type array, string given	RequestTask expects an array or empty input, string given
demo.rest.get		unchanged

This PR and #34 both add entries to the CHANGELOG Latest section: the one merged second needs a rebase.

Requirements

• Documentation updates
  • Reference
  • Changelog
• Unit tests

Breaking changes

• RequestTask fails on a 3xx / 4xx status code declared in valid_response_code #35: a 3xx / 4xx / 5xx status code listed in valid_response_code now outputs the response body (the task failed).
• RequestTask log_response logs the configured url and the response object #37: the context of the Response received debug log changes (result replaced by status_code, headers, content).
• Client::geUri() typo, MissingClientException::create() typing #39: geUri() is deprecated; a class extending MissingClientException and overriding create() must declare the same types.

🤖 Generated with Claude Code