Skip to content

fix: stop pr_checks alias forwarding empty inputs as overrides - #417

Merged
clouddrove-ci merged 1 commit into
masterfrom
fix/pr-checks-alias-empty-inputs
Aug 9, 2026
Merged

fix: stop pr_checks alias forwarding empty inputs as overrides#417
clouddrove-ci merged 1 commit into
masterfrom
fix/pr-checks-alias-empty-inputs

Conversation

@clouddrove-ci

Copy link
Copy Markdown
Member

The compat alias pr_checks.yml declares its inputs without defaults, then forwards all of them to pr-checks.yml. An input the caller leaves unset is forwarded as an empty string, which overrides the downstream default instead of falling back to it.

The visible symptom is PR title validation. pr-checks.yml builds:

FULL_REGEX="^(${TYPES})(\([a-zA-Z0-9_-]+\))?:\s+${{ inputs.subjectPattern }}$"

With subjectPattern forwarded as "" the regex becomes:

^(fix|feat|...)(\([a-zA-Z0-9_-]+\))?:\s+$

which requires the title to end immediately after type: . No valid Conventional Commit title can pass. Callers see PR title does not follow Conventional Commit format on titles that are correct.

checkLabels has the same problem in the other direction: a caller that omits it gets false forwarded, silently disabling the label check that is documented to default to true.

Fix: give the alias the same defaults as pr-checks.yml, so a caller that omits an input forwards the real default. Also forwards commitlintConfig, which the alias accepted nowhere and never passed through.

Verified all six inputs now match the target's defaults exactly.

Observed on clouddrove/terraform-aws-sqs, where PRs #30, #31 and #33 all failed title validation with valid titles. Worked around there by calling pr-checks.yml@v2 directly; terraform-aws-sns is still on the alias and affected.

@clouddrove-ci
clouddrove-ci merged commit 4df0df2 into master Aug 9, 2026
14 of 15 checks passed
@clouddrove-ci
clouddrove-ci deleted the fix/pr-checks-alias-empty-inputs branch August 9, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants