Repository navigation
chore: update Forge for UUID scalars - #358
Conversation
|
LGTM |
commit: |
|
✅ Approved — No issues found. The UUID scalar mappings cover both scalar switches in the generator, the test plugin import now targets the 0.3.0 interface, and new regression tests cover the UUID body and query cases. The decision is advisory: this comment never approves, blocks or requests changes on the pull request. ✅ All checks passed📋 Code Quality: ✅ LGTMNo issues found.
📝 Documentation: ✅ LGTMNo documentation changes are needed for this compatibility update. Reviewed commit: |
|
| mean | stddev | min | max | |
|---|---|---|---|---|
| PR | 279.9 ms | 6.3 ms | 271.3 ms | 297.1 ms |
| base | 275.5 ms | 6.8 ms | 267.0 ms | 294.5 ms |
Δ (PR vs base): ↑ +4.4 ms (+1.6%)
Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.
74e1e04 to
e40f9a7
Compare
|
LGTM |
e40f9a7 to
0a69412
Compare
|
LGTM |
Forge now exposes
format: uuidas a dedicated scalar. Updating the dependency without adapting the generator would drop UUID body flags and classify UUID query parameters asunknown.Pin Forge to the merged cloudflare/forge#48 build (
ca70d7f5d88da223e243bca25810199876242ea6), map UUID scalars to strings in body and parameter handling, and update the test plugin to the 0.3.0 interface. Add regression coverage for required/nullable UUID fields, referenced UUID arrays, and UUID query unions.Regeneration with the unchanged OpenAPI pin produces no tracked output changes, so this compatibility update needs no changeset.
Validation:
pnpm generate— generated output unchanged.pnpm check— passed.pnpm --filter cf test— 1,680 passed, 6 skipped.