Repository navigation
Skip reading the compliance region from the config file when it is set in the environment - #372
jamesopstad wants to merge 1 commit into
Conversation
…t in the environment
|
LGTM |
commit: |
|
| mean | stddev | min | max | |
|---|---|---|---|---|
| PR | 277.3 ms | 4.8 ms | 269.8 ms | 284.3 ms |
| base | 278.5 ms | 6.0 ms | 269.5 ms | 291.5 ms |
Δ (PR vs base): ↓ -1.2 ms (-0.4%)
Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.
|
✅ Approved — No issues found. The decision is advisory: this comment never approves, blocks or requests changes on the pull request. ✅ All checks passed🚀 Release: ✅ LGTMRisk: Low. 🔒 Security: ✅ LGTMNo security concerns. The compliance region from the environment still goes through 📖 AGENTS.md: ✅ LGTMThe existing guidance already says the compliance region resolves from its environment variable before project settings. This change matches that and needs no guidance update. 📋 Code Quality: ✅ LGTMI found no problems in this change.
⚡ Performance: ✅ LGTMThis change removes work. When the region comes from the environment, the function returns early and 📝 Documentation: ✅ LGTMThe changeset clearly describes the new priority and its effect. Reviewed commit: |
Fixes #207
Skip reading the compliance region from the config file when it is set in the environment
Resolve
CLOUDFLARE_COMPLIANCE_REGIONbefore project settings, matching the existing account ID priority. Commands with bothCLOUDFLARE_ACCOUNT_IDandCLOUDFLARE_COMPLIANCE_REGIONno longer evaluate acloudflare.config.tsfile solely to establish API context.