Repository navigation
Conversation
teamchong
force-pushed
the
feat/conformance-spec
branch
from
October 15, 2026 02:41
8f4ad3e to
44c14bb
Compare
teamchong
changed the title
srikrsna
reviewed
Oct 15, 2026
teamchong
force-pushed
the
feat/conformance-spec
branch
from
October 15, 2026 02:59
44c14bb to
d1ffe93
Compare
srikrsna
reviewed
Oct 15, 2026
teamchong
force-pushed
the
feat/conformance-spec
branch
from
October 15, 2026 18:00
d1ffe93 to
f7f6e08
Compare
teamchong
force-pushed
the
feat/conformance-spec
branch
from
October 15, 2026 18:11
f7f6e08 to
ea71832
Compare
srikrsna
reviewed
Oct 20, 2026
srikrsna
reviewed
Oct 21, 2026
| headers?: Record<string, Value>; // header parameters, by field name | ||
| body?: Value; // request body, with object keys in field names | ||
| }; | ||
| exchanges: Exchange[]; // in order; empty when the call must fail before sending |
Collaborator
There was a problem hiding this comment.
What is the case for more than 1?
Collaborator
Author
There was a problem hiding this comment.
only pagination (iterate) needed multiple exchanges, and client errors needed []
with both removed, now I changed it to exchange: Exchange.
Comment on lines
+122
to
+123
| | { kind: 'client'; message?: string } // refused before sending | ||
| | { kind: 'network'; message?: string }; // no response |
Collaborator
There was a problem hiding this comment.
Do we need to account for these?
Collaborator
Author
There was a problem hiding this comment.
removed both (along with disconnect: true in respond). Result now only covers response and api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC for a conformance suite any forge target can run.
Question it answers: if I write a new target plugin, how do I know it covers all the cases?
A case is data: one call, the HTTP exchanges the server must see, and the result the caller must get. A target generates a client for the suite API and wraps it in a small program that reads cases and writes results as JSON lines. A standalone runner serves the exchanges and checks the results:
forge-conformance --cases ./cases --client "node ./client.js" --expect-fail ./expected-failures.yamlThe runner builds nothing and knows nothing about the target's language, so targets outside this repo use it the same way.
conformance/RFC.mddefines the case schema, the client protocol and the runner's behaviour. The cases and suite API come once the shape is agreed.