Repository navigation
refactor: use cf and deploy previews - #55
Merged
Merged
Conversation
commit: |
petebacondarwin
approved these changes
Oct 20, 2026
| CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }} | ||
| CF_SEND_TELEMETRY: 'false' | ||
|
|
||
| # The build logs to stdout too; the JSON result is the last top-level |
Collaborator
There was a problem hiding this comment.
I think that cf previews deploy support WRANGLER_OUTPUT_FILE_DIRECTORY env var, that results in a nice clean JSONL file being written to disk. So you don't have to rely upon the stdout.
That being said, I think that after cloudflare/cf#355 we might have a clean stdout with the build logs sent to stderr??
Collaborator
Author
There was a problem hiding this comment.
Good to know! For now I commented out the deploy preview because the site is still internal, and I don't want to leak it (I deleted the comment too)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@astrojs/cloudflareso that we can start usingcfto deploy the website