Repository navigation
fix(events): fall back to the generic alert payload schema - #288
Open
acoyfellow wants to merge 1 commit into
Open
acoyfellow wants to merge 1 commit into
acoyfellow wants to merge 1 commit into
Conversation
alertEventDefinitions read EventPayloadSchemas directly, so adding an alert type to SUPPORTED_ALERT_TYPES without its own schema made events/list throw. Use the same AlertPayload fallback that delivery already uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alertEventDefinitionsreadsEventPayloadSchemas[alert.type]directly. If an alert type is added toSUPPORTED_ALERT_TYPESwithout its own schema,events/listthrows:Delivery already falls back to
AlertPayloadfor the same case. This PR makes both paths use one function,payloadSchemaFor.No behavior change today:
workers_observability_real_time_issueis the only supported type, and it keeps its own schema. It makes adding the next alert type a one-line change.Verified
universal_ssl_event_typeadded to the supported set,alertEventDefinitionsthrows. On this branch it returns both events, each with an object payload schema.falls back to the generic alert payload for types without their own schema.npm test: 483 passed.npm run test:events: 71 passed.tsc --noEmit,oxfmt --checkandoxlintpass (the one lint warning is already on main).