Replace once_cell with standard library primitives - #956
Open
ting-hong-shieh wants to merge 1 commit into
Open
Conversation
ting-hong-shieh
marked this pull request as ready for review
August 13, 2026 11:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #721.
This is a current-
mainreplacement for #732 and #735, which now conflict with the base branch.Summary
once_cell::sync::LazyandOnceCellwithstd::sync::LazyLockandOnceLock.OnceLock::setfollowed byget, and add a test that initializes a no-steal runtime from four threads.once_celldeclarations from the workspace crates.once_cellcan still appear transitively through third-party crates; this change removes Pingora's direct dependency on it.Testing
cargo fmt --all -- --checkcargo +1.85.0 check --workspace --exclude pingora-foundationscargo check --workspacecargo test -p pingora-runtime test_no_steal_runtime_concurrent_initialization -- --nocapturecargo test --doccargo clippy --all-targets --all -- --allow=unknown-lints --deny=warningscargo macheteThe full library, binary, and integration test command passed all targets that do not require OpenResty. The local host does not have OpenResty, so
pingora-proxy'stest_basicandtest_upstreamtargets could not start their mock origin; the repository CI installs OpenResty before running them.