test(typegen): pack vinext without rebuilding the shared dist - #3496
Merged
Merged
Conversation
Member
Author
|
/bigbonk review for issues Please review exact head |
@vinext/cloudflare
create-vinext-app
@vinext/types
vinext
@cloudflare/workers-response-store
commit: |
Contributor
|
LGTM! |
Contributor
|
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tests/typegen.test.ts("installs @vinext/types transitively from packed vinext without Next.js") runspnpm packinpackages/vinext. That fires vinext'sprepack, which runsvp packwithclean: trueand wipespackages/vinext/distfor several seconds while it rebuilds.The unit project runs files in parallel (
maxWorkers: 3), and other unit files resolve vinext's package exports from that dist.tests/cache-adapters-build.test.ts("preserves the CDN response entrypoint through Cloudflare's virtual host entry") importsvinext/server/fetch-handler, and when it lands inside the rebuild window it fails with:Which files overlap depends on the shard schedule, so a change that only resizes unrelated test files can make this fail on every attempt. It does so on #3465 and every PR stacked above it, which pass on the parent #3463 with the same shard contents.
Fix
Pack vinext with
--config.ignore-scripts=true, so the test packs the dist the install already built instead of rebuilding the shared one. Without prepack the README copy no longer happens, so thewithPreservedFilewrapper that restoredpackages/vinext/README.mdis removed (the rest of the diff is dedent).Locally the test still passes, and
packages/vinext/dist/index.jskeeps its modification time across the run.