Skip to content

fix(release): exclude skipped packages from version bumps - #3526

Merged
james-elicx merged 2 commits into
mainfrom
codex/fix-private-fixture-release-plan
Sep 28, 2026
Merged

james-elicx merged 2 commits into
mainfrom
codex/fix-private-fixture-release-plan

Conversation

@james-elicx

@james-elicx james-elicx commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

When leaving beta, the Version Packages PR includes 12 private fixtures as @null, adds version: null to their manifests, and creates fixture changelogs (#3511). Changesets skips those packages when building its prerelease map, then treats the missing map entries as prereleases because undefined !== 0 (upstream issue).

Apply the installed Changesets release plan through our version runner after filtering version bumps for packages excluded by the configured skip policy. Preserve the CLI validation after expanding ignore globs, dependency-only updates, and explicit private-package versioning opt-ins. Document the CLI-scoped API imports for Knip. The next release PR regeneration will version the five public packages without touching fixture versions or changelogs.

Changesets versions, package dependencies, the lockfile, and current release artifacts are unchanged.

Validation:

  • Reproduced the original version: null failure before the fix.
  • All 93 release-tooling tests pass, including prerelease exit, skipped and ignored packages, private-package opt-in, changelog preservation, dependency-only updates, the following stable release, and rejection of public dependencies excluded by ignore globs while allowing development-only dependencies.
  • vp check and vp run knip pass.
  • Ran create-changeset.mts and the complete version.mts pipeline in a disposable checkout: all five public packages became 1.0.0; fixtures, apps, examples, and benchmarks had no manifest or changelog changes.

@pkg-pr-new

pkg-pr-new Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@vinext/cloudflare

npm i https://pkg.pr.new/@vinext/cloudflare@3526

create-vinext-app

npm i https://pkg.pr.new/create-vinext-app@3526

@vinext/types

npm i https://pkg.pr.new/@vinext/types@3526

vinext

npm i https://pkg.pr.new/vinext@3526

@cloudflare/workers-response-store

npm i https://pkg.pr.new/@cloudflare/workers-response-store@3526

commit: d92442f

@github-actions

Copy link
Copy Markdown
Contributor
Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original
response-store-demo preview production
workers-cache preview production
kv preview production
static-assets-cache preview production
static-export preview production
web preview production

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Performance benchmarks

Compared d92442f against base 94f1bd1 using alternating same-runner rounds. Next.js was unchanged and skipped.

0 improved · 0 regressed · 6 within ±1.5%

Scenario Framework Baseline Current Change
Client bundle size (gzip) vinext 142.3 KB 142.3 KB ⚫ +0.0%
Client entry size (gzip) vinext 130.4 KB 130.4 KB ⚫ +0.0%
Dev server cold start vinext 3.28 s 3.30 s ⚫ +0.4%
Production build time vinext 3.62 s 3.60 s ⚫ -0.5%
RSC entry closure size (gzip) vinext 128.3 KB 128.3 KB ⚫ -0.0%
Server bundle size (gzip) vinext 226.9 KB 226.9 KB ⚫ -0.0%

View detailed results and traces

🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

Review head d92442f. Focus on release-plan filtering, preserved Changesets validation, prerelease/stable behavior, and dependency-only updates. The fix must remain in vinext's release runner; Changesets dependency bumps or patches are not allowed.

@ask-bonk

ask-bonk Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@james-elicx
james-elicx merged commit 79ed2c9 into main Sep 28, 2026
83 checks passed
@james-elicx
james-elicx deleted the codex/fix-private-fixture-release-plan branch September 28, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant