fix(release): exclude skipped packages from version bumps - #3526
Merged
Merged
Conversation
@vinext/cloudflare
create-vinext-app
@vinext/types
vinext
@cloudflare/workers-response-store
commit: |
Contributor
|
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
Member
Author
|
/bigbonk review for issues Time limit: 8 minutes. Complete the review and post all findings within that limit. Review head d92442f. Focus on release-plan filtering, preserved Changesets validation, prerelease/stable behavior, and dependency-only updates. The fix must remain in vinext's release runner; Changesets dependency bumps or patches are not allowed. |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When leaving beta, the Version Packages PR includes 12 private fixtures as
@null, addsversion: nullto their manifests, and creates fixture changelogs (#3511). Changesets skips those packages when building its prerelease map, then treats the missing map entries as prereleases becauseundefined !== 0(upstream issue).Apply the installed Changesets release plan through our version runner after filtering version bumps for packages excluded by the configured skip policy. Preserve the CLI validation after expanding ignore globs, dependency-only updates, and explicit private-package versioning opt-ins. Document the CLI-scoped API imports for Knip. The next release PR regeneration will version the five public packages without touching fixture versions or changelogs.
Changesets versions, package dependencies, the lockfile, and current release artifacts are unchanged.
Validation:
version: nullfailure before the fix.vp checkandvp run knippass.create-changeset.mtsand the completeversion.mtspipeline in a disposable checkout: all five public packages became1.0.0; fixtures, apps, examples, and benchmarks had no manifest or changelog changes.