Skip to content

[wrangler] Fix deploy warning snapshots - #16353

Merged
petebacondarwin merged 1 commit into
mainfrom
codex/fix-deploy-warning-snapshots
Oct 19, 2026
Merged

petebacondarwin merged 1 commit into
mainfrom
codex/fix-deploy-warning-snapshots

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Fixes the deploy E2E snapshot failures blocking #16313 (failed job).

Update the workers_dev and preview_urls warning snapshots to name wrangler.toml, matching the fixture and the current deployment guidance. CI stops at the first failed assertion, so the adjacent preview URL snapshot needs the same update.

Validation:

  • pnpm -w test:ci -F wrangler -- src/__tests__/deploy/workers-dev.test.ts — 57 tests passed.
  • Formatting and lint checks for packages/wrangler/e2e/deploy.test.ts.
  • The credentialed deploy E2E tests were not run locally because Cloudflare test credentials are unavailable.

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this only corrects existing test snapshots.

No changeset is needed for this test-only change.

Note

This is a contribution from an AI agent: Codex (GPT-6), at a maintainer's request.


Devin Review

@petebacondarwin petebacondarwin added the ci:no-changeset-required Skip pull request checks for a valid changeset label Oct 19, 2026
@changeset-bot

changeset-bot Bot commented Oct 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a8da16e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Oct 19, 2026
@workers-devprod
workers-devprod requested review from a team and dario-piotrowicz and removed request for a team October 19, 2026 08:18
@workers-devprod

workers-devprod commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@ask-bonk

ask-bonk Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@clanky-the-clanker

Copy link
Copy Markdown

✅ Approved — Test-only snapshot update with no issues found.

The decision is advisory: this comment never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

The change updates the expected warning text in the deploy E2E snapshots. It is limited to packages/wrangler/e2e/deploy.test.ts.


Reviewed commit: a8da16ed

@pkg-pr-new

pkg-pr-new Bot commented Oct 19, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@16353

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@16353

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@16353

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@16353

@cloudflare/containers-shared

npm i https://pkg.pr.new/@cloudflare/containers-shared@16353

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@16353

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@16353

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@16353

miniflare

npm i https://pkg.pr.new/miniflare@16353

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@16353

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@16353

@cloudflare/runtime-types

npm i https://pkg.pr.new/@cloudflare/runtime-types@16353

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@16353

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@16353

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@16353

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@16353

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@16353

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@16353

wrangler

npm i https://pkg.pr.new/wrangler@16353

commit: a8da16e

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Oct 19, 2026
@petebacondarwin
petebacondarwin merged commit 89cc3c7 into main Oct 19, 2026
98 of 104 checks passed
@petebacondarwin
petebacondarwin deleted the codex/fix-deploy-warning-snapshots branch October 19, 2026 08:52
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:no-changeset-required Skip pull request checks for a valid changeset

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants