Skip to content

Upgrade Vite to 8.3.4 and remove patch - #16371

Open
sapphi-red wants to merge 2 commits into
cloudflare:mainfrom
sapphi-red:remove-vite-patch
Open

sapphi-red wants to merge 2 commits into
cloudflare:mainfrom
sapphi-red:remove-vite-patch

Conversation

@sapphi-red

@sapphi-red sapphi-red commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

This PR tries to fix the ecosystem-ci failure: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/39237196963/job/118009029061

This PR reverts #15650 and upgrades Vite to 8.3.4 now that vitejs/vite#22934 is fixed.

No changeset is required because this only changes internal tooling and CI behavior.

cc @petebacondarwin

close #15647


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: it shouldn't change the user facing behavior
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: it shouldn't change the user facing behavior

A picture of a cute animal (not mandatory, but encouraged)


Devin Review

@changeset-bot

changeset-bot Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 67d6391

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

This comment was marked as outdated.

@github-actions github-actions Bot closed this Oct 20, 2026
@github-project-automation github-project-automation Bot moved this from Untriaged to Done in workers-sdk Oct 20, 2026
@workers-devprod
workers-devprod requested review from a team and edmundhung and removed request for a team October 20, 2026 03:48
@workers-devprod

workers-devprod commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]

This comment was marked as resolved.

@github-project-automation github-project-automation Bot moved this from Done to Untriaged in workers-sdk Oct 20, 2026
@clanky-the-clanker

Copy link
Copy Markdown

This pull request was not reviewed automatically because its author does not have write access to this repository. A maintainer with write access can start a review by commenting clanky review (or clanker review or @clanky-the-clanker review), optionally followed by instructions (e.g. clanky review focus on the retry logic).

@petebacondarwin petebacondarwin self-assigned this Oct 20, 2026
@petebacondarwin petebacondarwin moved this from Untriaged to In Review in workers-sdk Oct 20, 2026
@pkg-pr-new

pkg-pr-new Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@16371

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@16371

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@16371

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@16371

@cloudflare/containers-shared

npm i https://pkg.pr.new/@cloudflare/containers-shared@16371

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@16371

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@16371

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@16371

miniflare

npm i https://pkg.pr.new/miniflare@16371

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@16371

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@16371

@cloudflare/runtime-types

npm i https://pkg.pr.new/@cloudflare/runtime-types@16371

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@16371

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@16371

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@16371

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@16371

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@16371

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@16371

wrangler

npm i https://pkg.pr.new/wrangler@16371

commit: 67d6391

@petebacondarwin

Copy link
Copy Markdown
Contributor

clanky review

@petebacondarwin petebacondarwin added the ci:no-changeset-required Skip pull request checks for a valid changeset label Oct 20, 2026

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from In Review to Approved in workers-sdk Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:no-changeset-required Skip pull request checks for a valid changeset

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

[Vite plugin] Playground test can hang in Vite server.close() during teardown

3 participants