Skip to content

[vite-plugin] Backport Workflow storage cleanup to v1 - #16379

Draft
petebacondarwin wants to merge 3 commits into
codex/vite-v1-backport-16371from
codex/vite-v1-backport-16183
Draft

petebacondarwin wants to merge 3 commits into
codex/vite-v1-backport-16371from
codex/vite-v1-backport-16183

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Vite plugin v1 forwards local Explorer endpoints to Miniflare and provides Workflow bindings in dev/preview. Consume the Workflow storage cleanup from #16183 through Miniflare 5.20261019.2-beta, including serialized instance deletion/recreation and native disk persistence. The retained v1 plugin has no createTestHarness API; removed public dependency source and upstream tests remain absent.

Draft: npm publication and full validation are blocked. Open main release #16377 now proposes Miniflare 5.20261019.2-beta, Wrangler 4.152.0, workers-utils 0.48.0, workers-auth 0.15.0, deploy-helpers 0.22.2, and containers-shared 0.23.2; every version returned npm HTTP 404 this run. The previous intended Wrangler 4.151.4 is superseded by that pending minor release. Keep Miniflare pins consistent across the plugin, retained remote-bindings, and account-id fixture, and update the plugin's Wrangler peer minimum.

Couple the matching helpers here, at the earliest backport requiring Wrangler 4.152.0: Wrangler's configuration/Binding types and retained remote-bindings share workers-utils, including its unique INHERIT_SYMBOL; deploy-helpers consumes these upload bindings, containers-shared consumes configuration types, and workers-auth must use the same UserError class for startup error preservation. Keep cli-shared-helpers 0.2.7 and unrelated test-helper consumers unchanged. These intended pins still require publication-time type/build validation; they are not claimed as validated releases.

Stacked on #16406, above #16378/#16373. Earlier merged #16333 already supplies Miniflare 5.20261019.1-beta, Wrangler 4.151.3, and #15708's Workflow cleanup. The separate Hyperdrive backport supplies its independently necessary retained proxy adaptation; do not repeat these runtime/helper pins there. Preserve all private workspace:* references and intentional v1 removals.

The lockfile remains the parent's actual published metadata; frozen installation is deliberately blocked until publication. No invented tarballs or integrity hashes. After publication, run pnpm install to regenerate it, then build, all workspace checks/types, retained suites, and existing Workflow dev/preview playgrounds before marking ready. The Vite maintenance parent passed build, retained suites, and all checks; those results do not validate the intended runtime versions. Current draft CI failures are ERR_PNPM_OUTDATED_LOCKFILE, consistent with the recorded blocker. Manifest formatting, pinning, whitespace, and description validation pass.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: upstream covers dependency source; existing plugin Workflow integration suites must run after publication. Proposed-version validation is blocked, and this draft is not ready to merge.
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this consumes compatible runtime fixes for existing Workflow behavior, described in the plugin changeset.

Note

This is a contribution from an AI agent: Codex, preparing maintainer-requested v1 backports.

@petebacondarwin

Copy link
Copy Markdown
Contributor Author

@edmundhung (recorded author of #16183) and @dario-piotrowicz (verified human ant-core approver), could you please check this Vite plugin v1 backport and approve it when it is ready and looks good?

This draft consumes the runtime fix through the intended Miniflare 5.20261019.2-beta / Wrangler 4.151.4 pins from pending release #16377. It preserves real lockfile metadata while npm publication is pending; lockfile regeneration and build/type/Workflow playground validation must follow. V1 uses the runtime's Workflow bindings and local Explorer; removed public source, test-harness APIs and upstream tests are not copied. Earlier #16333 already supplies the #15708 cleanup fix, and this stacks on #16378.

@petebacondarwin
petebacondarwin added this pull request to stack #16347 October 21, 2026 08:50
@petebacondarwin
petebacondarwin force-pushed the codex/vite-v1-backport-16183 branch from df495a4 to 485dd71 Compare October 21, 2026 09:08
@changeset-bot

changeset-bot Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8b6d943

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin
petebacondarwin removed this pull request from stack #16347 October 21, 2026 14:13
@petebacondarwin
petebacondarwin changed the base branch from codex/vite-v1-backport-16259 to codex/vite-v1-backport-16371 October 21, 2026 14:13
@petebacondarwin
petebacondarwin added this pull request to stack #16411 October 21, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant