[Aikido] Fix 3 security issues in baseline-browser-mapping, @ungap/structured-clone, feed - #2967
Open
aikido-autofix[bot] wants to merge 1 commit into
Open
Conversation
Contributor
|
Tip Atmos Pro
No affected stacks workflow was detected for this pull request. |
|
Warning This PR is blocked from merging because a required semver label is missing. You'll need to add one before this PR can be merged. |
Dependency Review✅ No vulnerabilities or license issues found.Scanned Files
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2967 +/- ##
=======================================
Coverage 83.44% 83.44%
=======================================
Files 1923 1923
Lines 188072 188072
=======================================
+ Hits 156928 156937 +9
+ Misses 23227 23217 -10
- Partials 7917 7918 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
|
💥 This pull request now has conflicts. Could you fix it @aikido-autofix[bot]? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Upgrade baseline-browser-mapping, @ungap/structured-clone, and feed to fix DoS via process termination and RCE via unsafe deserialization.
why
✅ 3 CVEs resolved by this upgrade
This PR will resolve the following CVEs:
getCompatibleVersions()andgetAllVersions()functions callprocess.exit()on invalid configuration options, allowing attackers to terminate the entire host process via user-controlled input. This denial-of-service vulnerability is fixed by throwing catchable errors instead.deserializefunction unsafely instantiates constructors from attacker-controlled input, allowing remote code execution through dangerous constructors likeFunctionorWorker. The vulnerability stems from missing validation of constructor names before instantiation.urlin enclosures or processing XML feeds.✅ Code not affected by breaking changes.
✅ No breaking changes affect this codebase. The methods
getCompatibleVersions()andgetAllVersions()from the baseline-browser-mapping package are not used anywhere in the codebase.All breaking changes by upgrading baseline-browser-mapping from version 2.10.43 to 2.11.0 (CHANGELOG)
getCompatibleVersions()andgetAllVersions()now throw anErrorinstead of callingprocess.exit()when unsupported option combinations are passed, requiring different error handlingreferences