[Aikido] Prevent path traversal attacks in skill reference resolution - #2971
Open
aikido-autofix[bot] wants to merge 2 commits into
Open
[Aikido] Prevent path traversal attacks in skill reference resolution#2971aikido-autofix[bot] wants to merge 2 commits into
aikido-autofix[bot] wants to merge 2 commits into
Conversation
…handling by validating reference paths remain within skill directory.
Contributor
|
Tip Atmos Pro
No affected stacks workflow was detected for this pull request. 
|
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Erik Osterman (Cloud Posse) (osterman)
added
the
patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
This patch addresses path traversal vulnerabilities in the skill marketplace installer by implementing strict validation of skill reference paths. The fix ensures that all reference paths are resolved relative to the skill directory and rejects absolute paths and parent directory traversal attempts (e.g., "../"). Changes were made to
pkg/ai/skills/marketplace/installer.goto use a newresolveSkillReferencePathvalidation function, with comprehensive test coverage added inpkg/ai/skills/marketplace/installer_test.goto verify both valid relative paths and malicious traversal attempts are handled correctly.why
references