fix: guard null Entrypoint/Cmd in step-summary inspect - #109
Closed
John C. Bland II (johncblandii) wants to merge 1 commit into
Closed
fix: guard null Entrypoint/Cmd in step-summary inspect#109John C. Bland II (johncblandii) wants to merge 1 commit into
John C. Bland II (johncblandii) wants to merge 1 commit into
Conversation
Images defining only ENTRYPOINT (no CMD) — or vice versa — made the summary step fail with 'jq: Cannot iterate over null', breaking ci-docker for consumers (e.g. slack-notifier, github-status-updater).
John C. Bland II (johncblandii)
added
the
patch
Contributor
Author
|
Closing as superseded: main independently landed the identical null-guard fix for the step-summary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
// []null guards to theDocker Inspectsummary step'sEntrypoint/Cmdjq expressionswhy
ENTRYPOINT(noCMD), or only aCMD, makedocker inspectreport the other field asnull, andjq'sjoincannot iterate over null — the step exits 5 and failsci-dockerfor any such consumer (hit byslack-notifierandgithub-status-updaterwhen they bumped from 1.15.1 to v3; both currently work around it withsummary: "false")jq -r '.[0].Config.Cmd // [] | join(" ")'returns an empty string for null inputreferences