Surgery Sound Update: Different tools, Different sounds - #13083
Surgery Sound Update: Different tools, Different sounds#13083Puckaboo2 wants to merge 26 commits into
Conversation
cmss13-ci
Bot
added
Sound
cmss13-ci
Bot
added
the
size/L
| #define SURGERY_TOOLS_PRY list(\ | ||
| /obj/item/tool/surgery/retractor = SURGERY_TOOL_MULT_IDEAL,\ | ||
| /obj/item/tool/surgery/hemostat = SURGERY_TOOL_MULT_SUBOPTIMAL,\ | ||
| /obj/item/tool/crowbar = SURGERY_TOOL_MULT_SUBSTITUTE,\ |
There was a problem hiding this comment.
Retracting skin requires fine manipulation and a small tool head. That is to say, I don't think a crowbar would be anything more than SURGERY_TOOL_MULT_AWFUL at that task.
There was a problem hiding this comment.
This was literally copied from the list of tools that the retract skin step had. That would be a balance change that would need to be approved, but I get what you are saying.
| ) | ||
|
|
||
| ///Tools used to apply a skin graft after Eschar removal surgery. | ||
| #define SURGERY_TOOLS_APPLY_GRAFT list(\ |
There was a problem hiding this comment.
Might I also suggest adding bandages to this list as an SURGERY_TOOL_MULT_BAD_SUBSTITUTE substitute? Typically burns are dressed with gauze when skin grafts aren't available/possible.
There was a problem hiding this comment.
I'd argue gauze should be considered 'awful' because this is the 2100s and technology has advanced much further than gauze. Gauze should be a last-ditch option.
Honestly, though, that's out of scope for this PR. The only reason I'm making new datums to lists is to make it easier to group tools for sound applications. As I copy-pasted them, they remained unchanged from the original list the surgical steps had.
| if(!surface_modifier) | ||
| surface_modifier = SURGERY_SURFACE_MULT_AWFUL | ||
| for(var/obj/surface in get_turf(target)) | ||
| for(var/obj/surface in target.loc) |
There was a problem hiding this comment.
Why the change? We generally prefer to use get_turf due to its ability to handle weird error states.
There was a problem hiding this comment.
Oh, it's the reverse you guys want? That's fine. I'll fix it.
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cm13-github
removed
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
3 participants
About the pull request
This PR adds different sounds for different surgical tools depending on the step. Note: Not all tools have different sounds. Just some.
Maints, pls tell me in the Discord if something isn't in the changelog. I'll fix it immediately--no need to draft the PR.
Explain why it's good for the game
Did you hear a surgical drill while you were using a fire axe? No, you didn't. Not this update.
Testing Photographs and Procedure
Screenshots & Videos
new incision sounds
https://github.com/user-attachments/assets/b5b2a77c-afba-42cc-8fe4-c7f5bd54d523
New sounds for opening and repairing bones
https://github.com/user-attachments/assets/22c0ff66-9c25-44db-9638-7f984aee4be2
New sound for the Fix-O-Vein
https://github.com/user-attachments/assets/6aa494e3-64be-40a7-b2a2-b80a25b6757d
New sounds for applying skin grafts
https://github.com/user-attachments/assets/d51c53b3-1fca-419b-b27f-c0c723987fa9
New sounds for cauterizing wounds
https://github.com/user-attachments/assets/bfe5d7a8-e170-4f11-9d7b-2d347c6e43da
Changelog
🆑 Puckaboo2
code: Adds some defines for groups of surgery tools used for steps.
fix: Most tools making inappropriate sounds during surgery steps, like a knife using saw drilling noises when cutting bone, should not happen anymore.
fix: Tools that utilize toolhit sounds during failed steps have been restored.
fix: Using the IMS no longer tells you it made a bloody incision.
soundadd: The IMS, laser scalpel, bone gel, and ointment have their own sets of preop and success sounds. Some are splices of old sound files, while some are brand new.
soundadd: The Fix-O-Vein has a unique sound while using it to initiate flesh-and-vein-mending-type surgeries, while all weapons that chop instead of saw receive the same sound set of repetitive chopping when initiating a surgery step that cuts through bone.
soundadd: Cigarettes/lighters and welding tools have sounds for initiating cauterizations.
soundadd: The screwdriver uses its sound sets properly when initiating and successfully drilling rods through or applying plates on bones.
soundadd: Synthgrafts and ointment have sounds for initiating and successfully applying grafts during eschar surgeries.
soundadd: Surgery Line, cloth, and cable coils, whenever used as surgical tools, always use sewing noises to mend flesh and blood vessels.
soundtweak: Increased the volume of ointment spreading on skin a little bit so it is clearly audible.
/:cl: