Weed unit tests - #13089
Open
Red-byte3D wants to merge 10 commits into
Open
Conversation
cmss13-ci
Bot
added
Feature
antlersss
reviewed
Sep 5, 2026
antlersss
left a comment
antlersss
left a comment
Contributor
There was a problem hiding this comment.
Overall looks pretty good, but the test fail messages need some work to be more descriptive. People reading test failures generally don't have the full context to what's happening internally during a test, so it helps to be as descriptive as possible. I suggested changes to some of the fail messages to give you an idea as to what we might be looking for.
It might seem redundant, but you probably should also add header comments to each of these tests explaining what each of them is testing for.
boskoramen
requested changes
Sep 5, 2026
github-project-automation
Bot
moved this from Awaiting Review
to Changes Requested
in Review Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
adds unit tests for weeds i'lla dd anything thats missing
Explain why it's good for the game
unitests
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
add: Unit test for weeds
fix: proper returns after boiler qdel effect code
/:cl: